util: remove redundant declaration#14199
Closed
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:util.js-err
Closed
util: remove redundant declaration#14199vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom vsemozhetbyt:util.js-err
vsemozhetbyt wants to merge 1 commit intonodejs:masterfrom
vsemozhetbyt:util.js-err
Conversation
This module is already required in the top scope (Line 3).
nodejs-github-bot
added
the
util
Contributor
Author
refack
approved these changes
Jul 12, 2017
lpinca
approved these changes
Jul 12, 2017
cjihrig
approved these changes
Jul 12, 2017
tniessen
approved these changes
Jul 12, 2017
TimothyGu
approved these changes
Jul 13, 2017
Contributor
Author
|
@Trott Can we consider CI fails unrelated? |
jasnell
approved these changes
Jul 14, 2017
Contributor
|
This one (only fail in last run) https://ci.nodejs.org/job/node-test-commit-plinux/10191/nodes=ppcbe-ubuntu1404/ is unrelated #14206 |
Contributor
Author
|
Landed in 2288e3f |
vsemozhetbyt
added a commit
that referenced
this pull request
Jul 14, 2017
This module is already required in the top scope (Line 3). PR-URL: #14199 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
This module is already required in the top scope (Line 3). PR-URL: #14199 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Jul 19, 2017
This module is already required in the top scope (Line 3). PR-URL: #14199 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
util
This module is already required in the top scope (Line 3). So if I do not miss any intended side effects this declaration can be deleted.